Add solana checks to make file #407
Conversation
agusaldasoro
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xAustinWang
|
Could you put this in a make target? Something like "make solana_checks". The pre commit config would call the target (and maybe do the yubi key thing). We could also call that target as part of CI to ensure these files are always consistent. Add a call to the new target here: |
All Solana Validations are run in https://github.com/smartcontractkit/chainlink-ccip/blob/feat/add-docs/.github/workflows/solana.yml The pre-commit hook is just for local dev |
| cd ./contracts && anchor build | ||
|
|
||
| .PHONY: solana-checks | ||
| solana-checks: clippy anchor-go-gen format gomodtidy lint-go rust-tests go-tests build-contracts |
There was a problem hiding this comment.
The anchor-go-gen is already building the contracts, could you please remove that redundancy to bring down the time it takes to run this command?
| solana-checks: clippy anchor-go-gen format gomodtidy lint-go rust-tests go-tests build-contracts | |
| solana-checks: clippy anchor-go-gen format gomodtidy lint-go rust-tests go-tests |
There was a problem hiding this comment.
No, I needed it to recreate the IDL, as the tests modify them adding the program_ids
|
The Solana Contracts have many validations regarding format and autogenerated code, this new make command needs to be run only when a file under
chains/solanawas modified and auto fix style issues, and auto generates all needed files.